-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apply h1 thickline globally #2169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to check all the proper documentation + working example is also there and up to date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the h1 CSS and create example in this base folder: /sites/h1
Like the breadcrumb folder structure: https://github.com/wet-boew/GCWeb/tree/master/sites/breadcrumbs
- Create a single SCSS file for the h1 style
- Remove the old h1 style (like you did)
- Link that newly SCSS in this main SCSS file, near the other heading style - https://github.com/wet-boew/GCWeb/blob/master/sites/theme.scss#LL35C6-L35C6
- Create the dedicated working example (EN and FR) for the h1
- Document in those page the version and a code sample
a. I do think it could be version 1.0.1, a patch change considering there is not change required for the author neither the implementor. We would need to check the public versioning API to be sure. It could be seen as a Minor/Major visual change.
b. Code sample: I do think we have a variant with the [id=wb-cont] and another one without it. And there is some variant enhance with RDFa + schema.org - Create the index.json-ld file (the name of the componentName need to be same as the folder name.
1563b39
to
aeb05f0
Compare
aeb05f0
to
c520bb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to reorganize the documentation according to our latest documentation template prototype.
You can see how the "Change set" and "Iteration" are documented under the technical documentation section.
c520bb6
to
96c1ba0
Compare
96c1ba0
to
d4418d8
Compare
d4418d8
to
6ba7333
Compare
6ba7333
to
d923bf0
Compare
d923bf0
to
9920fbc
Compare
a20266a
to
a2a91a6
Compare
a2a91a6
to
1ce1a2e
Compare
1ce1a2e
to
9fef0b8
Compare
9fef0b8
to
f0304b1
Compare
3d14e9d
to
dc45539
Compare
dc45539
to
a6535a3
Compare
a6535a3
to
eabe006
Compare
@duboisp Can you remove me and Eric as reviewers? Can you remove Jennifer as an assignee? |
eabe006
to
1572a9b
Compare
1572a9b
to
a5173a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should clean up, which can be done on or immediately after, remove any use of "gc-thickline" in our pages.
Do we have a note about that somewhere saying that CSS class is useless because it is now the default for h1?
a5173a1
to
997cce1
Compare
This commit adds the main page title component, which includes the SCSS file, HTML template, JSON data, and Markdown documentation for both English and French versions. The component provides a default H1 style with a short bold red underline for use in Canada.ca websites. It also includes guidance and code samples for implementing the component with and without RDFa + schema.org markup.
997cce1
to
16856f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review and tested. It does work as expected.
Once this PR is merged, the following 2 actions is required immediatly after or they can be included with the release PR.
- Add the technical note about the obsoleted
gc-thickline
in the index.json-ld - Regenerate the GCWeb sites assets (ex: _data/sites.json ...) to keep GCWeb web site functional.
Pre-approved upon quick review of the unresolved conversation by @duboisp |
As per DTO email, this is the update for the H1 globally: